I'm not totally sure what's causing this so apologies for the somewhat vague issue. Hopefully you'll have a better idea!

I have a query with a couple of joins on it already and when I attempt to filter it, I'm getting the following exception:

  File "/usr/local/lib/python3.9/site-packages/sqlalchemy_filters/filters.py", line 563, in apply
    query = self._apply_join(query)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy_filters/filters.py", line 364, in _apply_join
    if is_already_joined(query, join[0]):
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy_filters/utils.py", line 37, in is_already_joined
    return join_table in [_[0] for _ in query._legacy_setup_joins]
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/sql/operators.py", line 366, in __eq__
    return self.operate(eq, other)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/orm/attributes.py", line 317, in operate
    return op(self.comparator, *other, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 1302, in __eq__
    self.property._optimized_compare(
  File "/usr/local/lib/python3.9/site-packages/sqlalchemy/orm/relationships.py", line 1690, in _optimized_compare
    raise sa_exc.ArgumentError(
sqlalchemy.exc.ArgumentError: Mapped instance expected for relationship comparison to object.   Classes, queries and other SQL elements are not accepted in this context; for comparison with a subquery, use DataSource.owner.has(**criteria).

I have these two related models eg:

class Organisation(Base):
    __tablename__ = "organisations"
    id = Column(INTEGER, primary_key=True)
    name = Column(VARCHAR(64))


class User(Base):
    __tablename__ = "users"
    id = Column(INTEGER, primary_key=True)
    name = Column(VARCHAR(64))
    email = Column(VARCHAR(64))
    organisation_id = Column(Integer, ForeignKey("organisations.id"))
    organisation = relationship("Organisation")

And then a filter for filtering users:

class UserFilter(Filter):
    name = Field()
    email = Field(lookup_operator=ContainsOperator)
    organisation = Field(field_name="organisation.name")

    class Meta:
        model = User

If I then create a query with a join and attempt to apply the filter to the query:

query = db_session.query(User).join(Organisation)
my_filter = UserFilter(data={"organisation": "test_org"}, query=query)
query = my_filter.apply()
print(str(query))

It creates this second joining of the organisations table:

SELECT 
    users.id AS users_id, 
    users.name AS users_name, 
    users.email AS users_email, 
    users.organisation_id AS users_organisation_id
FROM users 
    JOIN organisations ON organisations.id = users.organisation_id
    JOIN organisations ON organisations.id = users.organisation_id
WHERE organisations.name = ?

Hey,

Really love the package, great work! :+1:

I've just been having some difficulty using the order_by with a UnaryExpression. Example from the docs:

MyFilter(data={"order_by": User.first_name.asc()})

This results in:

TypeError: Boolean value of this clause is not defined

It seems that this is the offending line. Would it be possible to get this changed to something like this?

order_by = self.data.get("order_by", self._order_by)

Here's a minimal working example that I was using to test this:

from sqlalchemy import Column, VARCHAR, INTEGER, create_engine
from sqlalchemy.orm import declarative_base, Session
from sqlalchemy_filters import Filter, Field


Base = declarative_base()


class User(Base):
    __tablename__ = "users"
    id = Column(INTEGER, primary_key=True)
    name = Column(VARCHAR(64))
    email = Column(VARCHAR(64))


class UserFilter(Filter):
    name = Field()

    class Meta:
        model = User


engine = create_engine("sqlite://")
with Session(engine) as session:
    query = session.query(User)
    my_filter = UserFilter(data={"order_by": User.name.desc()}, query=query)
    query = my_filter.apply()

Thanks!

Hi, Using your library, and this seemed to be not filtering with address_id and business_id base_filter = ScreeningHistoryFilter(data={"address_id":f"{address_id}", "business_id":f"{business_id}", "page":pagination_params.page_index, "page_size": pagination_params.page_size, "order_by": sort_params.sort_fields}, session= self.db)

Below is the filter class: `class ScreeningHistoryFilter(Filter): address_id: Field() business_id: Field() # start_range: DateTimeField(field_name ='create_tz', lookup_operator = GTEOperator) # end_range: DateTimeField(field_name ='create_tz', lookup_operator = LTEOperator)

class Meta:
    model = V_Address_Screening_History`