so here is the error I found.

Traceback (most recent call last):
  File "2dshooter/RUN.py", line 522, in <module>
    s7_2 = button7_2.tick(screen, mouse_pos, mouse_single_tick, glitch)
  File "2dshooter/RUN.py", line 236, in tick
    return self.action(self.args)
  File "2dshooter/RUN.py", line 139, in start_sp
    game.main(difficulty = arg, draw_los = draw_los, dev_tools = dev, skip_intervals = check_box_inter.__dict__["checked"], map = maps_dict[selected_map]["map"])
  File "2dshooter/game.py", line 1223, in main
    pygame.transform.scale(screen, fs_size, full_screen)
ValueError: Destination surface not the given width or height.

there's some recap: I have a 4k monitor, and I noticed this in the code.

fs_size = 1920, 1080

game would not start (I hear some music and a black screen, then it crashes)- it would give this error at start:

anim/glitch/0010.png
RESET
Traceback (most recent call last):
  File "2dshooter/RUN.py", line 658, in <module>
    pygame.transform.scale(screen, fs_size, full_screen)
ValueError: Destination surface not the given width or height.

when I changed the fs_size var to be:

fs_size = 1920*2,1080*2

which is my resolution, the loading screen starts up. everything looks fine. the latest error (the top one of this post) happens when I hit start game on single or multiplayer after I made that change.

It's also hard for me to debug - because when I run the debugger in vscode - whatever screen the terminal is displayed in is the one pygame (not the monitor pygame is in ) seems to want to measure and get the dimensions of. (so I can't seem to have vscode open on the side and pygame on the center monitor without producing a

ValueError: Destination surface not the given width or height.

at some point - because of some mismatch of measurement.

I'll try another DE and maybe it's just an I3 thing, but I think it's a 4k/1080p or a (single/dual monitor ?) thing.

The function does not work properly, since it finds infinite routes for some reason, so I just break the loop after certain amount of time. Usually it finds some route, but in certain spots (in Manufactory in top right corner) the zombies don't find any route so they try to calculate a new route every tick, grinding the game in to halt.

`def calc_route(start_pos, end_pos, NAV_MESH, walls): """ Calculates the shortest route to a point using the navmesh points """

if los.check_los(start_pos, end_pos, walls):
    return [end_pos]
dist_start = {}
dist_end = {}
for nav_point in NAV_MESH:
    point = nav_point["point"]
    if los.check_los(start_pos, point, walls):
        dist_start[los.get_dist_points(start_pos, point)] = nav_point
    if los.check_los(end_pos, point, walls):
        dist_end[los.get_dist_points(end_pos, point)] = nav_point
try:
    start_nav_point = dist_start[min(dist_start.keys())]
    end_nav_point = dist_end[min(dist_end.keys())]
except:
    return [end_pos]


complete_routes = []
routes = []
for conne in start_nav_point["connected"]:
    routes.append([start_nav_point["point"], conne])

while routes != []:
    if len(routes) > 200:   #sometimes continues infinetely, so the loop must be broken
        break
    route = routes[0]
    routes.remove(route)
    point = route[-1]
    point_2 = get_point_from_list(point, NAV_MESH)
    if end_nav_point["point"] in point_2["connected"]:
        route.append(end_nav_point["point"])
        complete_routes.append(route)

    else:
        for point_3 in point_2["connected"]:
            if point_3 in route:
                continue
            if route.copy() + [point_3] in routes:
                continue
            routes.append(route.copy() + [point_3])
shortest_route = {"dist" : 10000, "route" : []}


for route in complete_routes:
    route_ref = {"dist" : 0, "route" : route}
    last_pos = start_pos
    for point in route:
        route_ref["dist"] += los.get_dist_points(last_pos, point)

    if route_ref["dist"] < shortest_route["dist"]:
        shortest_route = route_ref

return shortest_route["route"]`

Zombie spawned with id 2292 Zombie spawned with id 3799 Zombie spawned with id 2694 Zombie spawned with id 908 Zombie spawned with id 2981 Zombie spawned with id 3522 Zombie spawned with id 2547 Zombie spawned with id 2555 Zombie spawned with id 2949 EXPLOSION ADDED Zombie spawned with id 1227 Zombie spawned with id 1894 Zombie spawned with id 2729 Zombie spawned with id 215 Zombie spawned with id 608 Zombie spawned with id 3177 Zombie spawned with id 3805 Zombie spawned with id 4026 Dropping: {'item': <classes.Item object at 0x000000000EA30708>, 'amount': 1} Zombie spawned with id 42 DROP: 33.32363348513192 {33.32363348513192: ['HE Grenade', 0], 29.32363348513192: ['Heroin', 4], 28.77363348513192: ['Cocaine', 4.55], 27.773 48513192: ['Diazepam', 5.55], 25.77363348513192: ['45 ACP', 7.55], 18.77363348513192: ['50 CAL', 14.55], 15.773633485 92: ['9MM', 17.55], 9.77363348513192: ['12 GAUGE', 23.55], 6.773633485131921: ['7.62x39MM', 26.55], 3.773633485131920 ['Sentry Turret', 29.55], 0.7736334851319242: ['Barricade', 32.55]} KEY 32.55 DROP 33.32363348513192 Zombie spawned with id 794 Zombie spawned with id 591 Zombie spawned with id 1082 Zombie spawned with id 3930 Zombie spawned with id 879 STILL TO BE REMOVED: 5 STACK AMOUNT: 5 0 DELETING SLOT Zombie spawned with id 1896 Dropping: {'item': <classes.Item object at 0x000000000EA30708>, 'amount': 1} GRENADE INIT STILL TO BE REMOVED: 1 STACK AMOUNT: 2 1 throwing nade HIT Traceback (most recent call last): File "RUN.py", line 558, in main() File "RUN.py", line 419, in main s7_2 = button7_2.tick(screen, mouse_pos, mouse_single_tick, glitch) File "C:\python\2dshooter-contrib\button.py", line 63, in tick return self.action(arg) if arg != None else self.action(self.args) File "RUN.py", line 125, in start_sp app.start_sp(args) File "C:\python\2dshooter-contrib\app.py", line 40, in start_sp full_screen_mode = full_screen_mode) File "C:\python\2dshooter-contrib\game.py", line 1072, in main x.tick(screen, map_boundaries, player_pos, camera_pos, grenade_list, explosions, expl1, map, walls_filtered) File "C:\python\2dshooter-contrib\armory.py", line 155, in tick self.molotov_explode(map) File "C:\python\2dshooter-contrib\armory.py", line 117, in molotov_explode grenade_list.remove(self) ValueError: list.remove(x): x not in list

Hey I came from reddit and these are my suggestions for you

• use F-strings instead of concatenation
• use one-line if/else statements as you can !
• return immediately in functions instead of declaring extra variable
• use comprehensions
• merge nested if statements
• use CONSTANT variables (for example you can have something like : WHITE_COLOR = [255,255,255] instead of repeating the color code many times)
• use with keyword for opening/closing files

we should apply these rules as far as the code readability stay safe, good luck

C:\python\2dshooter>python RUN.py pygame 2.1.2 (SDL 2.0.18, Python 3.7.4) Hello from the pygame community. https://www.pygame.org/c Traceback (most recent call last): File "RUN.py", line 6, in from values import * File "C:\python\2dshooter\values.py", line 7, in <modul from screeninfo import get_monitors ModuleNotFoundError: No module named 'screeninfo'

Added top links to subjects - added sub categorization of todos. Note important to do is adding testing and getting automatic testing working in github. I'm not familiar with testing suites with python (just javascript) - so can't give any usable recommendations

Bumps numpy from 1.20.1 to 1.21.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

empty tests... but hopefully I or someone will fill them out.

and a minor change with get_string - now inherits from Weapon / game_object. cleaner code.

{35.18666611632174: ['HE Grenade', 0], 31.18666611632174: ['Heroin', 4], 30.636666116321738: ['Cocaine', 4.55], 29.63666 6116321738: ['Diazepam', 5.55], 27.636666116321738: ['45 ACP', 7.55], 20.636666116321738: ['50 CAL', 14.55], 17.63666611 6321738: ['9MM', 17.55], 11.636666116321738: ['12 GAUGE', 23.55], 8.636666116321738: ['7.62x39MM', 26.55], 5.63666611632 1738: ['Sentry Turret', 29.55], 2.6366661163217415: ['Barricade', 32.55], 0.6366661163217415: ['Molotov', 34.55]} KEY 34.55 DROP 35.18666611632174 Zombie spawned with id 1341 Zombie spawned with id 3116 Zombie spawned with id 1558 PARTICLE IN WALL, KILLING PARTICLE IN WALL, KILLING PARTICLE IN WALL, KILLING PARTICLE IN WALL, KILLING PARTICLE IN WALL, KILLING PARTICLE IN WALL, KILLING Zombie spawned with id 3662 Traceback (most recent call last): File "RUN.py", line 601, in main() File "RUN.py", line 462, in main s7_2 = button_start_mp.tick(screen, mouse_pos, mouse_single_tick, glitch) File "C:\python\2dshooter-contrib\button.py", line 61, in tick return self.action(arg) if arg != None else self.action(self.args) File "RUN.py", line 137, in start_sp app.start_sp(args) File "C:\python\2dshooter-contrib\app.py", line 42, in start_sp full_screen_mode = full_screen_mode) File "C:\python\2dshooter-contrib\game.py", line 339, in main quit_button.tick(screen, mouse_pos, click_single_tick, glitch) File "C:\python\2dshooter-contrib\button.py", line 61, in tick return self.action(arg) if arg != None else self.action(self.args) File "C:\python\2dshooter-contrib\game.py", line 71, in quit RUN.main() File "C:\python\2dshooter-contrib\RUN.py", line 462, in main s7_2 = button_start_mp.tick(screen, mouse_pos, mouse_single_tick, glitch) File "C:\python\2dshooter-contrib\button.py", line 61, in tick return self.action(arg) if arg != None else self.action(self.args) File "C:\python\2dshooter-contrib\RUN.py", line 137, in start_sp app.start_sp(args) File "C:\python\2dshooter-contrib\app.py", line 42, in start_sp full_screen_mode = full_screen_mode) File "C:\python\2dshooter-contrib\game.py", line 631, in main x.tick(screen, camera_pos,enemy_list,0, walls_filtered, player_pos) File "C:\python\2dshooter-contrib\game_objects\turret.py", line 125, in tick self.clean_up() File "C:\python\2dshooter-contrib\game_objects\turret.py", line 116, in clean_up func.render_cool(huuto,[turret_rect[0]+35-camera_pos[0], turret_rect[1]+35-camera_pos[1]],self._tick,16,True, screen = screen) NameError: name 'turret_rect' is not defined

no tests are actually written: but the automatic testing for github PR's and pushes are done. I had some trouble actually hooking up x11 or any display in the github container - so dummy driver for testing should be fine. to facilitate that I added a try block in values to have a default fallback if screeninfo fails (it does in the testing env - and that looks like it might be a package issue over there.) now we just need to write tests...

as far as I can currently tell - everything is up and running.

if anything is broken it should only be a minor fix.

further cleanup will be done - this could still be a lot better

todo: make it so the general object handles outside interactions - and sub_objects can be 'pure', in that they don't require anything from values/func/classes etc. making them easier to test.

Friend of mine checked the multiplayer tab and the ip text bar showed his local ip, even though it should be his public ipv4 address. ipv4 is crucial for the multiplayer. Can anyone check the tab and see if your correct ipv4 shows up?