Describe the bug

Hi, I'm seeing a segfault and error on Mac with OpenCL and different array data types.

• f32 - success
• f64 - segfault
• s32 - error (stack trace below)

  File "/usr/local/lib/python3.9/site-packages/khiva/matrix.py", line 231, in stomp_self_join
    raise Exception(str(error_message.value.decode()))
Exception: stomp_self_join: ArrayFire Exception (Internal error:998):
In function cl::Program opencl::buildProgram(const vector<std::__1::string> &, const vector<std::__1::string> &)
In file src/backend/opencl/compile_module.cpp:128
OpenCL Device: Intel(R) Iris(TM) 

To Reproduce

It's easiest to reproduce with the Python library (but think it's probably related to the C++ code).

from khiva.array import Array, dtype
from khiva.library import get_backend_info, set_backend, KHIVABackend
from khiva.matrix import stomp_self_join

# everything works with the CPU backend
# set_backend(KHIVABackend.KHIVA_BACKEND_CPU)

print(get_backend_info())

# success
a = Array.from_list([1, 2, 3, 4, 5], dtype.f32)
stomp_self_join(a, 3)

# segfault
a = Array.from_list([1, 2, 3, 4, 5], dtype.f64)
stomp_self_join(a, 3)

# error
a = Array.from_list([1, 2, 3, 4, 5], dtype.s32)
stomp_self_join(a, 3)

Expected behavior

No segfault or error, like with the CPU backend.

Environment information:

• OS: Mac OS 11.1
• Khiva Version: 0.5.0
• Khiva dependencies versions: ArrayFire 3.7.3, Boost 1.74.0

Here's the output of get_backend_info():

ArrayFire v3.7.3 (OpenCL, 64-bit Mac OSX, build default)
[0] APPLE: Intel(R) Iris(TM) Plus Graphics, 1536 MB

Additional context

Let me know if there's any I can do to help debug.

Not sure if this is on my end or in one of my shared libraries causing the problem.

Here's the error during the build. https://gist.github.com/zpzim/a7added1e63587e162f871383e33b1dc

It might be related to Intel TBB. I get this error even when I comment out the entire test function

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Describe the bug Linking errors raise when building the project and linking against the libraries installed by conan. Errors sample:

CMakeFiles/features.dir/featuresTest.cpp.o: In function `testing::AssertionResult testing::internal::CmpHelperEQFailure<long long, int>(char const*, char const*, long long const&, int const&)':
/home/asem/.conan/data/gtest/1.8.1/bincrafters/stable/package/4a8c5b4cd3b4d45b83fff85d53160ea02ae5fa2d/include/gtest/gtest.h:1435: undefined reference to `testing::internal::EqFailure(char const*, char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'

The linking issue is fixed when linking the khiva tests against the same gtest version 1.8.0 that is built from its main repository.

Sample from CMakeCache.txt before fixing

//Path to a file.
GTEST_INCLUDE_DIRS:PATH=/home/asem/.conan/data/gtest/1.8.1/bincrafters/stable/package/4a8c5b4cd3b4d45b83fff85d53160ea02ae5fa2d/include

//Path to a library.
GTEST_LIBRARIES:FILEPATH=/home/asem/.conan/data/gtest/1.8.1/bincrafters/stable/package/4a8c5b4cd3b4d45b83fff85d53160ea02ae5fa2d/lib/libgtest.a

//Path to a library.
GTEST_MAIN_LIBRARIES:FILEPATH=/home/asem/.conan/data/gtest/1.8.1/bincrafters/stable/package/4a8c5b4cd3b4d45b83fff85d53160ea02ae5fa2d/lib/libgtest_main.a

After fixing

//Path to a file.
GTEST_INCLUDE_DIRS:PATH=/opt/gtest/include

//Path to a library.
GTEST_LIBRARIES:FILEPATH=/opt/gtest/lib/libgtest.a

//Path to a library.
GTEST_MAIN_LIBRARIES:FILEPATH=/opt/gtest/lib/libgtest_main.a

I am just reporting this case since it costed me a lot of time! Couldn't expect that conan might be the reason.

Hi, also wanted to let you know there are now Ruby bindings for Khiva. It's modeled after the Python bindings (with some minor changes to make it more Ruby-like). The C API was really nice to use and easy to follow.

If you have any feedback, feel free to let me know here or create an issue in the project. Thanks!

Make sure you have checked all steps below.

Description

• [x] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [x] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Description

• Added headers guards for avoid double inclusions.

Tests

• My PR does not need testing because it does not add any functional feature

Benchmarks

• [ ] My PR does not need benchmarks because are only changes in include for avoid double inclusions.

Commits

• Add headers guards in bindings includes for C and Java.

License

• Mozilla Public License 2.0 license header

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

Description

Visvalingam now runs transparently for float64 and float32 types.

Tests

Added DimensionalityTests.VisvalingamAF to test both scenarios.

Benchmarks

N/A

Make sure you have checked all steps below.

Description

• [ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

• [ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

• [ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

License

• [ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.

18/211 Test  #18: ClusteringTests.KShapeDouble .....................................***Failed   18.02 sec
Running main() from C:\dev\vcpkg\buildtrees\gtest\src\ase-1.10.0-9cde347ce0.clean\googletest\src\gtest_main.cc
Note: Google Test filter = ClusteringTests.KShapeDouble
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ClusteringTests
[ RUN      ] ClusteringTests.KShapeDouble
←[32m[----------]←[0m CPU backend, device: Intel CPU
[----------] CUDA backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_UHD_Graphics
unknown file: error: C++ exception with description "ArrayFire Exception (Internal error:998):
OpenCL Error (-59): Invalid Operation when calling clEnqueueMapBuffer
In function class af::array __cdecl af::matmul(const class af::array &,const class af::array &,const af_mat_prop,const af_mat_prop)
In file src\api\cpp\blas.cpp:20" thrown in the test body.
[  FAILED  ] ClusteringTests.KShapeDouble (17741 ms)
[----------] 1 test from ClusteringTests (17741 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (17741 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ClusteringTests.KShapeDouble

 1 FAILED TEST

17/211 Test  #17: ClusteringTests.KShapeFloat ......................................***Failed   18.88 sec
Running main() from C:\dev\vcpkg\buildtrees\gtest\src\ase-1.10.0-9cde347ce0.clean\googletest\src\gtest_main.cc
Note: Google Test filter = ClusteringTests.KShapeFloat
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ClusteringTests
[ RUN      ] ClusteringTests.KShapeFloat
←[32m[----------]←[0m CPU backend, device: Intel CPU
[----------] CUDA backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_UHD_Graphics
unknown file: error: C++ exception with description "ArrayFire Exception (Internal error:998):
OpenCL Error (-59): Invalid Operation when calling clEnqueueMapBuffer
In function class af::array __cdecl af::matmul(const class af::array &,const class af::array &,const af_mat_prop,const af_mat_prop)
In file src\api\cpp\blas.cpp:20" thrown in the test body.
[  FAILED  ] ClusteringTests.KShapeFloat (18594 ms)
[----------] 1 test from ClusteringTests (18594 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (18594 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ClusteringTests.KShapeFloat

 1 FAILED TEST

166/211 Test #166: MatrixTests.FindBestDiscordsMultipleProfiles .....................***Failed   19.85 sec
Running main() from C:\dev\vcpkg\buildtrees\gtest\src\ase-1.10.0-9cde347ce0.clean\googletest\src\gtest_main.cc
Note: Google Test filter = MatrixTests.FindBestDiscordsMultipleProfiles
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from MatrixTests
[ RUN      ] MatrixTests.FindBestDiscordsMultipleProfiles
←[32m[----------]←[0m CPU backend, device: Intel CPU
[----------] CUDA backend, device: GeForce_RTX_2060
C:\Users\MiguelArregui\workspace\khiva\test\matrixTest.cpp(1148): error: Expected equality of these values:
  subsequenceIndicesHost[0]
    Which is: 10
  0
←[32m[----------]←[0m OPENCL backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_UHD_Graphics
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_Core(TM)_i7-10875H_CPU @ 2.30GHz
[  FAILED  ] MatrixTests.FindBestDiscordsMultipleProfiles (19597 ms)
[----------] 1 test from MatrixTests (19597 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (19597 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MatrixTests.FindBestDiscordsMultipleProfiles

 1 FAILED TEST

74/211 Test  #74: FeaturesTests.FftAggregated ......................................***Failed   11.05 sec
Running main() from C:\dev\vcpkg\buildtrees\gtest\src\ase-1.10.0-9cde347ce0.clean\googletest\src\gtest_main.cc
Note: Google Test filter = FeaturesTests.FftAggregated
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from FeaturesTests
[ RUN      ] FeaturesTests.FftAggregated
←[32m[----------]←[0m CPU backend, device: Intel CPU
[----------] CUDA backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: GeForce_RTX_2060
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_UHD_Graphics
←[32m[----------]←[0m OPENCL backend, device: Intel(R)_Core(TM)_i7-10875H_CPU @ 2.30GHz
C:\Users\MiguelArregui\workspace\khiva\test\featuresTest.cpp(481): error: The difference between fft[3] and f4 is 1.1920928955078125e-06, which exceeds EPSILON, where
fft[3] evaluates to 3.642664909362793,
f4 evaluates to 3.6426661014556885, and
EPSILON evaluates to 9.9999999999999995e-07.
[  FAILED  ] FeaturesTests.FftAggregated (10790 ms)
[----------] 1 test from FeaturesTests (10790 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (10790 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FeaturesTests.FftAggregated

1 FAILED TEST